feat(i18n): convert reference input strings to use i18n primitives #4977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
bjoerge
approved these changes
Oct 5, 2023
| @@ -2,7 +2,7 @@ import React, {ComponentProps, ForwardedRef, forwardRef, useCallback, useMemo, u | |||
| import {from, throwError} from 'rxjs' | |||
| import {catchError, mergeMap} from 'rxjs/operators' | |||
| import * as PathUtils from '@sanity/util/paths' | |||
| import { | |||
| import type { | |||
There was a problem hiding this comment.
on an completely unrelated note, we might want to add an eslint rule to enforce this consistently throughout the codebase
| @@ -82,7 +82,7 @@ describe('simpleParser - errors', () => { | |||
| }) | |||
| test('unclosed tags', () => { | |||
| expect(() => simpleParser('foo <Icon> bar')).toThrow( | |||
| 'No matching closing tag for <Icon> found. Either make it self closing (e.g. "<Icon/>") or close it (e.g "<Icon>...</Icon>")', | |||
| 'No matching closing tag for <Icon> found. Either make it self closing (e.g. "<Icon/>") or close it (e.g "<Icon>...</Icon>").', | |||
There was a problem hiding this comment.
appreciate your attention to detail here :)
| * @param options - Optional options for the list formatter | ||
| * @returns Instance of `Intl.ListFormat` | ||
| */ | ||
| export function useIntlListFormat(options?: UseIntlListFormatOptions): Intl.ListFormat { |
Full Reportsanity
@sanity/types
sanity/desk
@sanity/diff
@sanity/block-tools
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/content
|
|
Component Testing Report Updated Oct 11, 2023 8:08 PM (UTC)
|
rexxars
force-pushed
the
feature/sdx-619-i18n-ref-input
branch
from
b66d126 to
0063c84
Compare
Makes it easier to get hold of a list formatter outside of locale resources, which you sometimes need, while ensuring it is using the correct (current) locale, and does not recreate the formatter on every render.
rexxars
force-pushed
the
feature/sdx-619-i18n-ref-input
branch
from
0063c84 to
3198bad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
componentsrequired for<Translate />component in order to discourage using it outside of cases where you actually need it<Translate>component<TimeAgo />) is broken - we knew this, but should probably be addressed soon in another PR. Some strings are coming from date-fns currently, while others are localized.